abh1sar opened a new pull request, #14388:
URL: https://github.com/apache/cloudstack/pull/14388
### Description
* `importVm importsource=shared` now accepts a Linstor pool, with diskpath
being the resource name without the cs- prefix.
* The check refuses a resource of another resource group, reports a resource
in use on any node as locked, and connects the disk on the checking host for
the read and disconnects it again.
* The imported volume keeps the hypervisor default format like a native
Linstor volume, as templates made from its snapshot backups take that format.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
1. Deployed a VM on a Linstor pool (two-node Linstor cluster)
2. Unmanaged it
3. Imported the VM, with the volume check on the node with the replica and
on the node without it
4. Verified the VM starts on both nodes
5. Verified a diskless resource is created for the check on the node
without the replica and removed after it
6. Verified the import is refused while the unmanaged VM is still running,
on either node
8. Took volume snapshots on the imported volume and created a template and
a volume from the snapshot
9. Verified the imported volume is recorded as QCOW2 like a natively
created Linstor volume, so templates from its snapshots match their file format
10. No failures or errors were observed
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
