Copilot commented on code in PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#discussion_r4246989585
########## .mvn/develocity.xml: ########## @@ -0,0 +1,50 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes" ?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> + +<develocity + xmlns="https://www.gradle.com/develocity-maven"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="https://www.gradle.com/develocity-maven https://www.gradle.com/schema/develocity-maven.xsd";> + <server> + <url>https://develocity.apache.org</url> + <allowUntrusted>false</allowUntrusted> + </server> + <buildScan> + <backgroundBuildScanUpload>#{isFalse(env['GITHUB_ACTIONS'])}</backgroundBuildScanUpload> + <obfuscation> + <ipAddresses>#{{'0.0.0.0'}}</ipAddresses> Review Comment: The expression syntax here (`#{{...}}`) is inconsistent with the other Develocity expressions in this file (which use `#{...}`) and is likely to fail XML/template parsing at runtime. Use the same `#{...}` expression form as elsewhere (or a plain literal) so the configuration is consistently parsed. ########## .mvn/develocity.xml: ########## @@ -0,0 +1,50 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes" ?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> + +<develocity + xmlns="https://www.gradle.com/develocity-maven"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="https://www.gradle.com/develocity-maven https://www.gradle.com/schema/develocity-maven.xsd";> + <server> + <url>https://develocity.apache.org</url> + <allowUntrusted>false</allowUntrusted> + </server> + <buildScan> + <backgroundBuildScanUpload>#{isFalse(env['GITHUB_ACTIONS'])}</backgroundBuildScanUpload> + <obfuscation> + <ipAddresses>#{{'0.0.0.0'}}</ipAddresses> + </obfuscation> + <publishing> + <onlyIf> + <![CDATA[authenticated]]> + </onlyIf> + </publishing> + </buildScan> + <buildCache> + <local> + <enabled>false</enabled> + </local> + <remote> + <enabled>false</enabled> + <storeEnabled>#{isTrue(env['GITHUB_ACTIONS'])}</storeEnabled> Review Comment: With `<enabled>false</enabled>`, the remote build cache is disabled, so `storeEnabled` is either ignored or misleading configuration. To match the PR intent ('caching disabled'), remove the `storeEnabled` line; alternatively, if you want to keep the switch for later, make `enabled` conditional in the same way so the configuration is internally consistent. ########## .github/workflows/ci.yml: ########## @@ -54,6 +54,8 @@ jobs: git status ipmitool -V - name: Build with Maven + env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} Review Comment: `DEVELOCITY_ACCESS_KEY` is being repeated across multiple steps/workflows. To reduce duplication and the risk of missing a step in the future, set it once at the job level (or workflow level) `env:` when all steps in the job need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
