rootnomad commented on PR #14089: URL: https://github.com/apache/cloudstack/pull/14089#issuecomment-6150170708
Good catch, you're right. A scheduled snapshot carries no name, so allocSnapshot auto-generates `vmname_volume_yyyyMMddHHmmss`. An hourly and a daily policy firing on the same volume in the same second get the same name, and the new check rejected one of them, which were both allowed before this PR. Fixed in e62a34e: the check now only runs when the caller supplied a name, so auto-generated names are left alone. The duplicate explicit name from the original report is still refused and recurring snapshots are unaffected. Verified on a KVM lab and added a unit test for the auto-generated path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
