Damans227 commented on code in PR #14089:
URL: https://github.com/apache/cloudstack/pull/14089#discussion_r4261578144
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1721,6 +1721,10 @@ public Snapshot allocSnapshot(Long volumeId, Long
policyId, String snapshotName,
if (snapshotName == null)
snapshotName = vmDisplayName + "_" + volume.getName() + "_" +
timeString;
+ if (_snapshotDao.findByVolumeIdAndNameNotInStatus(volumeId,
snapshotName, Snapshot.State.Destroyed, Snapshot.State.Error) != null) {
Review Comment:
that covers it, the check only runs for a name the caller gave in e62a34e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
