Damans227 commented on code in PR #14398:
URL: https://github.com/apache/cloudstack/pull/14398#discussion_r4270761593
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1220,6 +1220,7 @@ class VmStatsCollector extends AbstractStatsCollector {
protected void runInContext() {
try {
SearchCriteria<HostVO> sc =
createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance();
+ sc.addAnd("managementServerId", SearchCriteria.Op.EQ,
managementServerNodeId);
Review Comment:
does this change the totals for anyone with vm.stats.increment.metrics on?
those add up every saved row, so network and disk totals were counted once per
management server until now and will drop after upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]