weizhouapache commented on code in PR #14386:
URL: https://github.com/apache/cloudstack/pull/14386#discussion_r4269976804
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupChainKeys.java:
##########
@@ -48,6 +60,31 @@ public final class NASBackupChainKeys {
// "legacy-full" mode token (which sets make_checkpoint=0).
public static final String TYPE_LEGACY_FULL = "legacy-full";
+ /**
+ * In-memory backup-method sentinels used by {@code ChainDecision.method}:
how a backup is
+ * taken, independent of whether it is a full or an incremental ({@code
ChainDecision.mode}).
+ *
+ * <p>{@link #METHOD_QCOW2}: libvirt push-mode backup; incrementals come
from QEMU persistent
+ * dirty bitmaps (libvirt checkpoints), which only qcow2 volumes can
carry.</p>
+ */
+ public static final String METHOD_QCOW2 = "qcow2";
+
+ /**
+ * Content-based libvirt pull-mode backup, used for raw block-device
storage such as
+ * LINSTOR/DRBD which cannot carry persistent dirty bitmaps. A full is
written as a sparse
+ * qcow2 in a single pass; an incremental is a qcow2 overlay on the disk's
NBD export,
+ * safe-rebased onto the parent so it holds only the clusters that differ.
+ */
+ public static final String METHOD_CONTENT = "content";
Review Comment:
yes, this is just kept to be compatible with #14194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
