vishesh92 commented on code in PR #14405: URL: https://github.com/apache/cloudstack/pull/14405#discussion_r4281543612
########## api/src/main/java/org/apache/cloudstack/api/command/admin/storage/PreparePrimaryStorageForMaintenanceCmd.java: ########## @@ -33,8 +33,9 @@ import com.cloud.storage.StoragePool; import com.cloud.user.Account; -@APICommand(name = "enableStorageMaintenance", description = "Puts storage pool into maintenance state", responseObject = StoragePoolResponse.class, - requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) +@APICommand(name = "enableStorageMaintenance", + description = "Puts storage pool into maintenance state. The storage pool must be Up or Disabled", Review Comment: `ErrorInMaintenance` is not a state the primary storage is in generally. So, I don't think is too critical and it's just a command description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
