vishesh92 commented on code in PR #14405:
URL: https://github.com/apache/cloudstack/pull/14405#discussion_r4281565928
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -2550,14 +2550,15 @@ public PrimaryDataStoreInfo
preparePrimaryStorageForMaintenance(Long primaryStor
throw new InvalidParameterValueException(msg);
}
- if (!primaryStorage.getStatus().equals(StoragePoolStatus.Up) &&
!primaryStorage.getStatus().equals(StoragePoolStatus.ErrorInMaintenance)) {
+ if (!Arrays.asList(StoragePoolStatus.Up, StoragePoolStatus.Disabled,
StoragePoolStatus.ErrorInMaintenance).contains(primaryStorage.getStatus())) {
Review Comment:
not too critical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
