Damans227 commented on code in PR #14408:
URL: https://github.com/apache/cloudstack/pull/14408#discussion_r4286729712
##########
plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-control-node.yml:
##########
@@ -1,4 +1,3 @@
-## template: jinja
Review Comment:
put the jinja header back in 4d36ebe, so the cni config gets joined the same
way as before
##########
plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-control-node.yml:
##########
@@ -358,7 +357,6 @@ write_files:
sudo touch /home/cloud/success
echo "true" > /home/cloud/success
- {% if registry is defined %}
Review Comment:
done in 4d36ebe. the check is now `{% if "{{ registry.enabled }}" == "true"
%}` and the server fills in true or false for every cluster. there is a test
for each case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
