weizhouapache commented on PR #14407: URL: https://github.com/apache/cloudstack/pull/14407#issuecomment-6199783136
> overall the changes look good. > > nit: what happens if a running vm is added to a config drive network and then gets a second iso? looks like the iso goes to a drive that was never set up at start, so the attach fails until a restart. good point. if so, I would advise to reserve device id 3 as primary CD-ROM, and device id 4 as configdrive ISO. if the VM use IDE controller which support 2 CDROMs, the additional CD-ROMs (from 2nd CDROM) will use SATA controller, due to hardcoded `MAX_CDROMS_PER_VM = 2` , right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
