andrijapanicsb commented on PR #14407: URL: https://github.com/apache/cloudstack/pull/14407#issuecomment-6352081598
Thanks, @weizhouapache , for working through these conflicts, and @Damans227 for highlighting the remaining runtime limitation. Could we also revisit whether the second user ISO drive introduced in #13101 is worth retaining? My concern is the maintenance and regression cost relative to the requirements it addresses. For an attended Windows installation, a second CD-ROM is not required: the existing single-drive workflow is to swap the Windows ISO for the VirtIO ISO, load the storage driver, then restore the Windows ISO before continuing (like it was done for last 30 years or so, on physical HW). The original PR itself acknowledges that workflow. Two drives make this more convenient, but I would question whether that convenience alone justifies the additional complexity now needed around device allocation, config-drive coexistence, controller selection, and runtime attachment. One particularly concerning detail is that the KVM agent pre-allocates the extra CD-ROM even with `vm.iso.max.count=1`. As #14321 demonstrates, an empty drive can then conflict with a data disk. That extends the impact to users who have not opted into attaching multiple ISOs. I recognise the convenience that #13101 brings, but I would welcome concrete requirements beyond avoiding the manual swap before making a decision. My preference would be to reconsider the feature and, unless those requirements justify the ongoing cost, plan its deprecation and removal while retaining one user ISO drive alongside the separate config drive. Since it has shipped in 4.23, that would need a compatibility plan for existing attachments and API consumers. If we retain it, I think the minimum should be genuinely optional extra drives and predictable device assignments across config-drive changes and restarts. The older config-drive/data-volume conflict in #13484 still needs fixing regardless. I appreciate the work in this PR; I would just like us to assess whether supporting the additional user ISO drive remains the right trade-off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
