andrijapanicsb commented on PR #14272: URL: https://github.com/apache/cloudstack/pull/14272#issuecomment-6198546143
+1 to both of @Damans227 points. - Image formats: #13587 already handles qemu 10.1's "Supported image formats:" header on 4.22. The current pattern finds qcow2/raw/luks/rbd/vmdk in the 10.1 output quoted above, so the extra `create -o help` probe isn't needed. - `--target-is-zero`: main detects it with `isTargetZeroFlagSupported()` since #14256 (`--help` first, then a direct `convert --target-is-zero` probe that doesn't depend on help text). Backporting that method to 4.22 unchanged fixes 4.22 and avoids a conflict when 4.22 is merged forward. Note that zero-skipping is used on 4.22: backup restore, ScaleIO/PowerFlex, Linstor (zeroed devices) and StorPool encryption all ask for it. With qemu 10.x they currently write zeros into thin targets, so the second fix is worth having on 4.22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
