andrijapanicsb commented on PR #14272: URL: https://github.com/apache/cloudstack/pull/14272#issuecomment-6201726521
@sureshanaparti @nvazquez As offered, a unit test for the `--target-is-zero` probe is ready. It needs a small refactor of `isTargetZeroFlagSupported()`: the decision moves into a static method that takes qemu-img's output, with no change in behaviour. The new `QemuImgTargetZeroFlagTest` has six cases covering qemu before 5.0, 5.x–8.x (EL8, EL9.4) and 10.x, built from real qemu-img output. It needs neither qemu-img nor libvirt, so it runs in CI. That matters here: the smoke tests run on OL8, whose qemu still lists the flag in `--help`, so the qemu 10 probe path never runs there. I'll open it as a separate PR against main. For 4.22 it can go in together with the backport here; I'm happy to share the patch for this branch if that's easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
