nabassa1323 commented on code in PR #14399:
URL: https://github.com/apache/cloudstack/pull/14399#discussion_r4293242353
##########
ui/src/views/network/CreateSharedNetworkForm.vue:
##########
@@ -800,8 +800,10 @@ export default {
this.handleNetworkOfferingChange(null)
this.networkOfferings = []
getAPI('listNetworkOfferings', params).then(json => {
- this.networkOfferings =
json.listnetworkofferingsresponse.networkoffering || []
+ const offerings = json?.listnetworkofferingsresponse?.networkoffering
|| []
Review Comment:
None. On Shared, listNetworkOfferings also returns HTTP 200 with an empty
listnetworkofferingsresponse. No request fails in the Network tab; the
"Request failed" toast comes from the client-side TypeError path, same as
Isolated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
