Damans227 commented on code in PR #14399:
URL: https://github.com/apache/cloudstack/pull/14399#discussion_r4294937400
##########
ui/src/views/network/CreateSharedNetworkForm.vue:
##########
@@ -800,8 +800,10 @@ export default {
this.handleNetworkOfferingChange(null)
this.networkOfferings = []
getAPI('listNetworkOfferings', params).then(json => {
- this.networkOfferings =
json.listnetworkofferingsresponse.networkoffering || []
+ const offerings = json?.listnetworkofferingsresponse?.networkoffering
|| []
Review Comment:
in 4.22.1.0 that line already falls back to an empty list and shows the
shared warning. can you share the console error from the shared tab? it might
be the isolated tab erroring when the dialog opens
##########
ui/src/views/network/CreateIsolatedNetworkForm.vue:
##########
@@ -566,24 +574,30 @@ export default {
if (!isAdmin()) { // normal user is not aware of the VLANs in the
system, so normal user is not allowed to create network with network offerings
whose specifyvlan = true
params.specifyvlan = false
}
- if (forVpc !== null) {
+ if (forVpc !== undefined && forVpc !== null) {
params.forvpc = forVpc
}
this.networkOfferings = []
this.selectedNetworkOffering = {}
getAPI('listNetworkOfferings', params).then(json => {
- this.networkOfferings =
json.listnetworkofferingsresponse.networkoffering || []
- this.networkOfferings = this.networkOfferings.filter(offering =>
offering.fornsx === this.selectedZone.isnsxenabled)
- if (!this.selectedZone.routedmodeenabled) {
+ const offerings = json?.listnetworkofferingsresponse?.networkoffering
|| []
Review Comment:
thanks, that explains it. can we slim this to the isolated warning and the
l2 change? the empty list crash itself is already fixed on 4.22 and main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
