Damans227 commented on code in PR #13768:
URL: https://github.com/apache/cloudstack/pull/13768#discussion_r4295415418
##########
server/src/main/java/com/cloud/api/ApiServlet.java:
##########
@@ -237,17 +238,15 @@ void processRequestInContext(final HttpServletRequest
req, final HttpServletResp
// logging the request start and end in management log for easy
debugging
String reqStr = "";
- String cleanQueryString =
StringUtils.cleanString(req.getQueryString());
+ String cleanQueryString = getCleanQueryString(command,
req.getQueryString(), reqParams);
Review Comment:
should the access log keep the cleaned query string here? with this, any GET
call with userdata, or a GET addHost or createAccount, now logs only the
command name, and the existing cleaner already hides the access and secret keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
