weizhouapache opened a new pull request, #14456: URL: https://github.com/apache/cloudstack/pull/14456
### Description StorageVMSnapshotStrategy.canHandle() required either State.Allocated or a persisted vm_snapshot_details/STORAGE_SNAPSHOT row before it would claim a VM snapshot. A snapshot that fails before any underlying disk snapshot is taken (e.g. VM freeze fails because the QEMU guest agent is not connected) transitions to State.Error without ever persisting such a row, so canHandle() returned CANT_HANDLE and deletion fell back to DefaultVMSnapshotStrategy. That strategy sends a DeleteVMSnapshotCommand to the KVM agent, which requires a live libvirt domain - failing with 'Domain not found' once the VM is stopped, and blocking both snapshot deletion and VM destruction. Let StorageVMSnapshotStrategy also claim ownership of snapshots in State.Error even when no disk-snapshot details were persisted: there is nothing on the hypervisor to clean up in that case, and deleteVMSnapshot()/deleteDiskSnapshot() are already safe no-ops when the details list is empty - no libvirt domain is required. Fixes #13972 <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
