Pearl1594 commented on code in PR #14460:
URL: https://github.com/apache/cloudstack/pull/14460#discussion_r4348161880
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -5456,6 +5457,20 @@ private void
handlePowerOnReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
}
}
+ private void reconcileNicsForRunningVm(final VMInstanceVO vm) {
+ final VMInstanceVO runningVm = _vmDao.findById(vm.getId());
+ if (runningVm == null || runningVm.getType() !=
VirtualMachine.Type.User || runningVm.getState() != State.Running ||
runningVm.getHostId() == null
Review Comment:
Oh misinterpreted your statement earlier - I thought you meant does the fix
impact VRs - my bad :facepalm:
That said, I dont think VR was VR is impacted by the issue, and even if it
did, we never really took into account VRs nic count, so this fix should only
be limited to userVMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
