DaanHoogland commented on code in PR #14379:
URL: https://github.com/apache/cloudstack/pull/14379#discussion_r4346652915
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java:
##########
@@ -89,6 +90,54 @@ public KVMStoragePool createStoragePool(String name, String
host, int port, Stri
}
}
+ @Override
+ public boolean deleteStoragePool(String uuid) {
Review Comment:
@Pearl1594 , sonar has a good point here; this either returns true or throws
an exception. I realise it is an override but is the return needed at all?
(here or in `undefineInactiveClvmPool(..)`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
