sandeeplocharla commented on PR #13897: URL: https://github.com/apache/cloudstack/pull/13897#issuecomment-6413781561
> > Hi @winterhazel , let me know if you feel the latest changes to fix the NFS Cancel maintenance issue looks good? Will test the same on 4.21.1 branch and raise a diff there also. > > @sandeeplocharla thanks, the fix looks good. > > I pushed 3 commits to https://github.com/winterhazel/cloudstack/commits/13897/. Could you have a look and maybe include them here? I would require only [04bba56](https://github.com/apache/cloudstack/commit/04bba5686e27d78f65609ef1abb55a4049619532), as it fixes a regression and also prevents the code from sending unnecessary calls to the storage backend. I think we can then merge this PR once packaging is ready, as they are fairly safe changes. > > * [04bba56](https://github.com/apache/cloudstack/commit/04bba5686e27d78f65609ef1abb55a4049619532) fixes an issue where the SolidFireSharedPrimaryDataStoreLifeCycle hook would compute the min_iops/max_iops/burst_iops values and save them as details in the database, but then the _storagePoolDao.updateDetails(id, details) in StorageManagerImpl would erase these. It also optimizes the update command so that the lifecycle hook is not called for operations that only change the pool's name or its tags. > * [95bbde4](https://github.com/apache/cloudstack/commit/95bbde46d49cffc057cc137e127a038916929595) makes the no-details storage pool delete path consistent with with the one was already changed, so that it also does not leave an unmounted NFS pool in libvirt. This path is used by some other workflows. I think it is worth including here as we're already including the fix for the maintenance path. > * [30ae33f](https://github.com/apache/cloudstack/commit/30ae33ffe67f7282370f2bb4ded162105b3aaddd) is a future proofing change, so that the update hook receives a pool object containing the updated values. It does not affect anything at the moment. Hi @winterhazel, if testing has been done for the changes that you've committed, we are good to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
