sandeeplocharla commented on PR #13897: URL: https://github.com/apache/cloudstack/pull/13897#issuecomment-6458457864
> > Hi @winterhazel, if testing has been done for the changes that you've committed, we are good to proceed. > > @sandeeplocharla ok, these commits were indeed manually tested. > > * For [95bbde4](https://github.com/apache/cloudstack/commit/95bbde46d49cffc057cc137e127a038916929595), I validated that changing the scope of a NFS primary storage from zone to cluster (which uses the no-detail path) makes libvirt unmount and undefine the pool on hosts outside the destination cluster. > * For [04bba56](https://github.com/apache/cloudstack/commit/04bba5686e27d78f65609ef1abb55a4049619532) and [30ae33f](https://github.com/apache/cloudstack/commit/30ae33ffe67f7282370f2bb4ded162105b3aaddd), I validated that a name-only pool update does not affect its details (therefore, also does not issue any requests to the appliance), and that updating the capacity IOPS of a SolidFireShared pool correctly persists the recalculated min_iops/max_iops/burst_iops values (PS: I do not have access to a SolidFire storage, so I emulated one by updating the entry of a NFS storage so that the code believed it was a SolidFire storage, and skipped the calls to the appliance itself). Sure, thanks! @winterhazel. If everything is in order, please help me with the next steps @nvazquez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
