JoaoJandre commented on code in PR #14473:
URL: https://github.com/apache/cloudstack/pull/14473#discussion_r4413363527
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -1549,10 +1548,6 @@ public AsyncCallFuture<VolumeApiResult>
createManagedStorageVolumeFromTemplateAs
if (templateOnPrimary == null) {
templateOnPrimary =
createManagedTemplateVolume(srcTemplateInfo, destPrimaryDataStore);
-
- if (templateOnPrimary == null) {
- throw new CloudRuntimeException(String.format("Failed
to create template %s on primary storage: %s", srcTemplateInfo,
destPrimaryDataStore));
- }
Review Comment:
Is this related?
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1872,8 +1872,7 @@ private void checkPodAttributesForNonEdgeZone(final long
podId, final String pod
}
}
- final String checkPodCIDRs = _configDao.getValue("check.pod.cidrs");
- if (checkPodCIDRs == null || checkPodCIDRs.trim().isEmpty() ||
Boolean.parseBoolean(checkPodCIDRs)) {
+ if (ManagementServer.CheckPodCIDRs.value()) {
checkPodCidrSubnets(zone.getId(), podId, cidr);
Review Comment:
this will change the behavior, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
