DaanHoogland commented on code in PR #14473:
URL: https://github.com/apache/cloudstack/pull/14473#discussion_r4442619417
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -1549,10 +1548,6 @@ public AsyncCallFuture<VolumeApiResult>
createManagedStorageVolumeFromTemplateAs
if (templateOnPrimary == null) {
templateOnPrimary =
createManagedTemplateVolume(srcTemplateInfo, destPrimaryDataStore);
-
- if (templateOnPrimary == null) {
- throw new CloudRuntimeException(String.format("Failed
to create template %s on primary storage: %s", srcTemplateInfo,
destPrimaryDataStore));
- }
Review Comment:
not fully, It is just dead code encountered. (not that the
createManagedTemplateVolume throws on each occasion templateOnPrimary is null)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
