sureshanaparti opened a new pull request, #14568:
URL: https://github.com/apache/cloudstack/pull/14568
### Description
This PR fixes FKVM: createVolume / createTemplate from incremental snapshot
fails randomly, and managesnapshot.sh skips mkdir.
Always create the snapshot backup dir, surface qemu-img and agent errors
Fixes #14485
With `kvm.incremental.snapshot=true` and
`snapshot.backup.to.secondary=false`, createVolume / createTemplate from an
incremental snapshot fail randomly with "Failed to copy snapshot: ...
InvocationTargetException when invoking RPC callback for command:
copySnapshotAsyncCallback".
Changes:
- `managesnapshot.sh backup_snapshot()` now always runs `mkdir -p` on the
destination. The SSVM removes `snapshots/<account>/<volume>` after a temporary
copy is used, and the host's NFS client can still report the
directory as present from its dentry cache, so the old `[ ! -d ]` guard
skipped mkdir and qemu-img failed with ENOENT. mkdir forces a server-side
revalidation, so this is reliable.
- qemu-img's stderr is kept in the error returned to the management server
instead of being sent to /dev/null.
- `SnapshotServiceImpl.copySnapshotAsyncCallback` no longer NPEs when the
source snapshot has no `CreateSnapshotPayload` (the copy from snapshot flow).
The agent's error now reaches the API response and the failure cleanup runs.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
