Damans227 commented on code in PR #14568:
URL: https://github.com/apache/cloudstack/pull/14568#discussion_r4479757609
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java:
##########
@@ -494,7 +494,7 @@ protected Void
copySnapshotAsyncCallback(AsyncCallbackDispatcher<SnapshotService
SnapshotResult snapResult = new SnapshotResult(destSnapshot,
result.getAnswer());
if (result.isFailed()) {
try {
- if
(BooleanUtils.isTrue(createSnapshotPayload.getAsyncBackup())) {
+ if (createSnapshotPayload != null &&
BooleanUtils.isTrue(createSnapshotPayload.getAsyncBackup())) {
Review Comment:
@sureshanaparti if this copy fails during createVolume or createTemplate,
does the users snapshot get deleted now? looks like the cleanup below removes
the snapshot itself, not just the temp copy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
