github-advanced-security[bot] commented on code in PR #14570:
URL: https://github.com/apache/cloudstack/pull/14570#discussion_r4456347237
##########
.github/workflows/sbom.yml:
##########
@@ -35,15 +35,15 @@
with:
persist-credentials: false
+ - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e #
v6.4.0
+ with:
+ node-version: 24
+
- name: Generate UI SBOM
- uses: sbomify/sbomify-action@master
- env:
- LOCK_FILE: ui/package-lock.json
- OUTPUT_FILE: sbom.ui.cdx.json
- COMPONENT_NAME: cloudstack-ui
- COMPONENT_VERSION: ${{ github.ref_name }}
- UPLOAD: false
- ENRICH: true
+ # dev dependencies are build tooling and are not shipped in the UI
bundle
+ run: |
+ npx --yes @cyclonedx/[email protected] --package-lock-only --omit
dev \
Review Comment:
## SonarCloud / JavaScript package manager scripts should not be executed
during installation
<!--SONAR_ISSUE_KEY:AaGh6DbcuNFc7CzGLwPF-->"npx" can install packages
on-demand and run their lifecycle scripts. <p>See more on <a
href="https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGh6DbcuNFc7CzGLwPF&open=AaGh6DbcuNFc7CzGLwPF&pullRequest=14570";>SonarQube
Cloud</a></p>
[Show more
details](https://github.com/apache/cloudstack/security/code-scanning/233)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
