github-actions[bot] commented on issue #14599: URL: https://github.com/apache/cloudstack/issues/14599#issuecomment-6744187146
> [!WARNING] > threat detection engine error > The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding. > > <!-- gh-aw-threat-engine-error --> > > <details> > <summary>What happened</summary> > > The threat detection engine failed to produce results. > > Review the [workflow run logs](https://github.com/apache/cloudstack/actions/runs/42625769126) for details. > > </details> ## 🎯 Triage report `listSnapshots` fails with an NPE when a snapshot references a volume row that no longer exists. `CephSnapshotStrategy`, `ScaleIOSnapshotStrategy` and `StorageSystemSnapshotStrategy` call `getRemoved()` on the result of `findByIdIncludingRemoved()` without a null check, and every strategy is asked for `revertable`, so one bad row breaks the whole list call. The reporter proposes returning `CANT_HANDLE` when the volume is missing, as `DefaultSnapshotStrategy` already does. ### 📊 Assessment | Dimension | Value | Reasoning | | --- | --- | --- | | **Type** | type:bug | NPE in snapshot strategy selection | | **Component** | component:snapshot | Failure is in snapshot strategy `canHandle()` | | **Severity** | Severity:Major | One such snapshot breaks `listSnapshots` for all storage types | | **Labels** | type:bug, component:snapshot, Severity:Major | | | **Coding agent** | Suitable | Fix is specified: null-check and return `CANT_HANDLE` in the three strategies | ### 🔗 Similar issues - #14481 (related) — instance snapshot failures with `KvmFileBasedStorageVmSnapshotStrategy` - #14030 (related) — KVM VM snapshot merge leaves a volume path pointing to a missing file <details> <summary>💡 Notes and suggestions</summary> - Reproduction needs a snapshot whose `volume_id` has no matching row in `volumes`; the reporter got there via purge or manual DB cleanup. - Check whether other strategy `canHandle()` implementations have the same unguarded pattern. </details> > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/42625769126) · copilot · haiku55 · \~4 AIC · ⊞ 3.8K · [◷](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues) <details> <summary><sub>Add this agentic workflow to your repo</sub></summary> To install this agentic workflow, run ``` gh aw add githubnext/agentics/workflows/daily-issue-triage.md@139fa09ef17cde4135e696ff8e7af09bc5ddfa6e ``` </details> <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage --> <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, model: claude-haiku-5.5, id: 42625769126, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/42625769126 --> <!-- gh-aw-execution: {"version":1,"repo_id":"9759448","repository":"apache/cloudstack","aw_workflow_id":"daily-issue-triage","run_id":"42625769126","run_attempt":"1","run_url":"https://github.com/apache/cloudstack/actions/runs/42625769126","publishing_job":{"key":"safe_outputs","check_run_id":"129262122857"}} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
