Damans227 commented on code in PR #14000:
URL: https://github.com/apache/cloudstack/pull/14000#discussion_r4513349185


##########
engine/orchestration/src/main/java/com/cloud/cluster/agentlb/ClusterBasedAgentLoadBalancerPlanner.java:
##########
@@ -88,37 +88,54 @@ public List<HostVO> 
getHostsToRebalance(ManagementServerHostVO ms, int avLoad) {
         hostToClusterMap = sortByClusterSize(hostToClusterMap);

Review Comment:
   @DaanHoogland not really. the sort is old code, and your PR still gives away 
the right number of hosts. the bad order only changes which cluster gets split. 
fine to fix it separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to