bhouse-nexthop commented on code in PR #14112: URL: https://github.com/apache/cloudstack/pull/14112#discussion_r4517175485
########## engine/orchestration/src/test/java/com/cloud/vm/VirtualMachineManagerOverCommitTest.java: ########## Review Comment: Sorry for the slow reply on this one. I went with the second option: the overcommit logic is now its own `VirtualMachineManagerOverCommit` bean (declared in spring-engine-orchestration-core-context.xml), and `VirtualMachineManagerImpl` calls it from start, migrate and unmanage. The code moved unchanged. So `VirtualMachineManagerOverCommitTest` now tests that class directly, with one added test for the entry point. `VirtualMachineManagerImplTest` no longer stubs the cluster details; it just mocks the new bean. No change in behaviour. https://github.com/apache/cloudstack/pull/14112/commits/ac974d92db2aa60e2eda3181140ed96f55a80258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
