bhouse-nexthop commented on PR #14641:
URL: https://github.com/apache/cloudstack/pull/14641#issuecomment-6752448235
### Test report: response of a cluster-scoped updateConfiguration
**Summary:** `updateConfiguration` with `clusterid` now answers with the
value set for the cluster, not the global value.
**Environment**
- A CloudStack 24.0 (main) build with this PR, alongside some of my other
open PRs. One management server and one cluster. The PR is for main only.
- `drs.algorithm`: global value `balanced`, with no cluster-scoped value set
(no `cluster_details` row).
**Steps and results**
| Step | Result |
|---|---|
| `updateConfiguration name=drs.algorithm value=condensed
clusterid=<cluster>` | response
`{"name":"drs.algorithm","value":"condensed","scope":"cluster"}` |
| `listConfigurations name=drs.algorithm clusterid=<cluster>` | `condensed` |
| `listConfigurations name=drs.algorithm` (global) | still `balanced` |
| `resetConfiguration name=drs.algorithm clusterid=<cluster>` | cluster back
to `balanced`, no `cluster_details` row left |
Before this PR, the first call's response carried `"value":"balanced"`, the
global value, although `condensed` was stored for the cluster.
**Result:** pass.
**Not covered**
- Zone, account, domain and storage pool scopes. They go through the same
code; the unit test covers the cluster scope.
- Encrypted (Secure or Hidden) settings.
- The implicit scope a domain admin or user gets when calling without a
scope id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
