piyush5netapp commented on code in PR #14523:
URL: https://github.com/apache/cloudstack/pull/14523#discussion_r4525289686


##########
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java:
##########
@@ -551,7 +551,34 @@ public boolean migrateToObjectStore(DataStore store) {
 
     @Override
     public void updateStoragePool(StoragePool storagePool, Map<String, String> 
details) {
+        String newCapacityStr = 
details.get(PrimaryDataStoreLifeCycle.CAPACITY_BYTES);
+        if (newCapacityStr == null) {

Review Comment:
   It can also be called for iops change also. Since this method is generic 
update, instead of having null check , have not null check for changes fields. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to