famerico commented on issue #14663: URL: https://github.com/apache/cloudstack/issues/14663#issuecomment-6776710790
Thanks for the pointer. I checked it against the code and it matches what we see. - In the 4.22.1.1 tag, `LibvirtStorageAdaptor.createPhysicalDisk` only sends `NetworkFilesystem` and `Filesystem` to `createPhysicalDiskByQemuImg`; `SharedMountPoint` falls into `createPhysicalDiskByLibVirt`, which matches the missing `qemu-img create` line in our agent log. - In 4.23.0.0, #13537 adds `QEMU_IMG_MANAGED_POOL_TYPES` (NFS, Filesystem, SharedMountPoint), so SharedMountPoint goes through `qemu-img` and can get the LUKS options. - The #13537 merge commit is not in the 4.22.1.1 tag (which we run) and is in 4.23.0.0. Two questions: 1. Is the fix expected in 4.22.2? The PR was merged into `4.22`, but I could not find a 4.22.2 release or the PR listed in any release notes. 2. #14662 (manual pool selection creates the volume silently without encryption, `passphrase_id` NULL) happens before the agent creates the disk, in the management server. As far as I can tell #13537 does not touch that path. Is it covered by another change? We will retest on a version that contains #13537 and report back here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
