timmyzhu commented on PR #14688: URL: https://github.com/apache/cloudstack/pull/14688#issuecomment-6828811472
I'm not an official reviewer, but I do not believe this fixes the issue. It does not address the root cause, and I don't think it'll even workaround the issue. The root cause is the vddk detection is far too slow. Doing a search of the entire filesystem is not a good design and should be avoided. My recommendation would be to remove the detection, but I'm not a cloudstack developer or maintainer. If there's no way to remove the detection or change the detection to not scan the entire root filesystem, then this change only addresses one of the calls to detectVddkLibDir. As noted in the bug report, there's another case where detectVddkLibDir is called in the hostSupportsVddk function, and I believe this will likely cause the bug to persist. Generally, calling a host supports function is not expected to take dozens of minutes, which would occur when the detectVddkLibDir function is called within the function. Within the hostSupportsVddk function, moving the hostSupportsInstanceConversion() function call from the return to the beginning of this function could potentially workaround this issue. At minimum, this should be included in this PR and tested that it's working as expected, but it doesn't address the design issue with the detection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
