erikbocks commented on code in PR #12650:
URL: https://github.com/apache/cloudstack/pull/12650#discussion_r4550541169
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1702,7 +1702,7 @@ public VirtualMachineTemplate
createPrivateTemplate(CreateTemplateCmd command) t
}
DataStore store =
_dataStoreMgr.getImageStoreWithFreeCapacity(zoneId);
if (store == null) {
- throw new CloudRuntimeException("cannot find an image store
for zone " + zoneId);
+ throwExceptionForImageStoreObtentionFailure(zoneId, "create
template");
Review Comment:
This is a pattern adopted in another methods throughout de codebase.
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1702,7 +1702,7 @@ public VirtualMachineTemplate
createPrivateTemplate(CreateTemplateCmd command) t
}
DataStore store =
_dataStoreMgr.getImageStoreWithFreeCapacity(zoneId);
if (store == null) {
- throw new CloudRuntimeException("cannot find an image store
for zone " + zoneId);
+ throwExceptionForImageStoreObtentionFailure(zoneId, "create
template");
Review Comment:
This is a pattern adopted in another methods throughout the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
