Copilot commented on code in PR #14700:
URL: https://github.com/apache/cloudstack/pull/14700#discussion_r4575199531
##########
core/src/main/java/com/cloud/network/HAProxyConfigurator.java:
##########
@@ -50,7 +50,8 @@ public class HAProxyConfigurator implements
LoadBalancerConfigurator {
"\tuser haproxy", "\tgroup haproxy", "\tstats socket
/run/haproxy/admin.sock", "\tdaemon"};
private static String[] defaultsSection = {"defaults", "\tlog global",
"\tmode tcp", "\toption dontlognull", "\tretries 3", "\toption redispatch",
- "\toption forwardfor", "\toption httpclose", "\ttimeout connect
5000", "\ttimeout client 50000", "\ttimeout server 50000"};
+ "\toption forwardfor", "\toption httpclose", "\ttimeout connect
5000", "\ttimeout client 50000", "\ttimeout server 50000",
+ "\ttimeout client-fin 30s", "\ttimeout server-fin 30s"};
Review Comment:
A TCP client can legitimately call `shutdown(SHUT_WR)` to end its request
and keep waiting for a response; the new `server-fin 30s` timeout can terminate
that exchange if the backend is silent for more than 30 seconds, even with
`idleTimeout=0` or a longer idle timeout. Applying this fixed limit to every
TCP listener leaves affected applications unable to restore their previous
behavior. Keep a finite default, but make the FIN timeout independently
configurable so these protocols can allow longer response waits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]