winterhazel opened a new pull request, #14710:
URL: https://github.com/apache/cloudstack/pull/14710

   ### Description
   
   This PR fixes two ways in which scoped configuration pages could 
accidentally update settings at the global level.
   
   When accessing an account's page by clicking the `Account` column in a list, 
the page opens without the account ID in the URL. Because of this, any 
`updateConfiguration` executed on the page is sent without the `accountid`, 
allowing operators to accidentally update settings at the global level.
   
   In addition, the graphical interface also allows operators to update 
settings at a Management Server level; however, the ID of the selected 
Management Server was never provided to the API, which caused the settings to 
be changed globally as well.
   
   These issues have been fixed.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [x] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### How Has This Been Tested?
   
   - Opened an account's settings page from the `Account` column of a list and 
confirmed that a setting update is sent with the `accountid` and only affects 
that account, without changing the global value.
   - Opened a Management Server's settings page and confirmed that 
updates/resets are sent with the `managementserverid` and only affect the 
selected Management Server.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to