Copilot commented on code in PR #14716:
URL: https://github.com/apache/cloudstack/pull/14716#discussion_r4591142132
##########
.pre-commit-config.yaml:
##########
@@ -182,6 +182,8 @@ repos:
- id: fix-byte-order-marker
- id: forbid-submodules
- id: mixed-line-ending
+ - id: name-tests-test
+ args: [--pytest-test-first]
Review Comment:
The hook's default `files` pattern is `(^|/)tests/.+\.py$` (plural), so it
skips CloudStack's main suites under `test/integration/` and `systemvm/test/`.
For example, `systemvm/test/TestCsAddress.py` and
`test/integration/plugins/solidfire/TestVolumes.py` are never checked despite
not matching `test_*.py`; `--all-files` does not override this filter. Please
configure `files` for the intended test directories, exclude support modules,
and migrate or explicitly handle existing nonconforming test names so the check
actually enforces the intended standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]