RosiKyu commented on PR #11976:
URL: https://github.com/apache/cloudstack/pull/11976#issuecomment-6956224644

   @shwstppr thanks for confirming that this can be reopened and tested. Before 
I test it for 24.0, could you please:
   
   1. Merge main into the branch. 
   2. Check the open Copilot points, mainly this one: with 
`api.disallow.internal.ids=true` (the default), a numeric ID passed to a UUID 
parameter seems to be ignored instead of refused. For example 
`listVirtualMachines id=5` could return all VMs instead of an "invalid 
parameter" error. Is that intended? I will check it in my test.
   3. Confirm the default `true` is what we want for 24.0. Scripts that still 
pass numeric IDs to older APIs will stop working after the upgrade, so it needs 
a line in the release notes. @DaanHoogland your approval was before the default 
was changed, could you confirm it is still OK?
   
   The other Copilot points (setting description for `false`, unit tests for 
the new setting, the `isPre3x` name) are minor; tests would be nice to have.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to