Copilot commented on code in PR #13937:
URL: https://github.com/apache/cloudstack/pull/13937#discussion_r4604321513


##########
pom.xml:
##########
@@ -47,6 +47,7 @@
 
     <properties>
         <!-- keep in alphabetic order -->
+        
<project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>

Review Comment:
   Source releases (`tools/build/build_asf.sh:144`) and RPM source staging 
(`packaging/package.sh:170`) omit `.git`, so the revision goal cannot populate 
`git.commit.time` and these builds receive no usable reproducible timestamp. 
Preserve a concrete commit/release timestamp in source distributions, or 
provide a deterministic fallback when Git metadata is absent. Apply the same 
solution to `tools/checkstyle/pom.xml:28`, which does not inherit the root POM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to