DaanHoogland commented on code in PR #14641:
URL: https://github.com/apache/cloudstack/pull/14641#discussion_r4627858368
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1152,7 +1152,13 @@ public Configuration updateConfiguration(final
UpdateCfgCmd cmd) throws InvalidP
encryptEventValueIfConfigIsEncrypted(config, value),
scope != null ? scope : ConfigKey.Scope.Global.name());
- return _configDao.findByName(name);
+ ConfigurationVO updatedConfig = _configDao.findByName(name);
+ if (updatedConfig != null && scope != null) {
+ // The configuration table holds the global value. Report the
value just set in the
+ // requested scope instead. This object is only used for the
response; it is not persisted.
Review Comment:
```suggestion
// just return the updated value as it was set on the scoped
version.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]