if concurrent snapshot happening on the same vm, throw invalid parameter exception to user. Reviewed-by: Frank
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/1eb20ee0 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/1eb20ee0 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/1eb20ee0 Branch: refs/heads/master Commit: 1eb20ee09559a505a6f5cc60bbdfa601f439194f Parents: 8f2bd45 Author: Edison Su <[email protected]> Authored: Tue Dec 9 15:38:58 2014 -0800 Committer: Edison Su <[email protected]> Committed: Wed Dec 17 14:35:42 2014 -0800 ---------------------------------------------------------------------- server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/1eb20ee0/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java index 1e13682..a3eb7b0 100755 --- a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java +++ b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java @@ -938,7 +938,7 @@ public class SnapshotManagerImpl extends ManagerBase implements SnapshotManager, List<SnapshotVO> activeSnapshots = _snapshotDao.listByInstanceId(volume.getInstanceId(), Snapshot.State.Creating, Snapshot.State.CreatedOnPrimary, Snapshot.State.BackingUp); if (activeSnapshots.size() > 0) { - throw new CloudRuntimeException("There is other active snapshot tasks on the instance to which the volume is attached, please try again later"); + throw new InvalidParameterValueException("There is other active snapshot tasks on the instance to which the volume is attached, please try again later"); } }
