CLOUDSTACK-8375: VCenter port group verification - return as PASS if no 
physical networks in zone

Signed-off-by: SrikanteswaraRao Talluri <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8a5b1e60
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8a5b1e60
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8a5b1e60

Branch: refs/heads/master
Commit: 8a5b1e60a4fc75ad57b9b127d1c6f13c202415c4
Parents: 4d05c3b
Author: Gaurav Aradhye <[email protected]>
Authored: Sat Apr 11 15:35:51 2015 +0530
Committer: SrikanteswaraRao Talluri <[email protected]>
Committed: Mon Apr 13 16:58:14 2015 +0530

----------------------------------------------------------------------
 tools/marvin/marvin/lib/common.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8a5b1e60/tools/marvin/marvin/lib/common.py
----------------------------------------------------------------------
diff --git a/tools/marvin/marvin/lib/common.py 
b/tools/marvin/marvin/lib/common.py
index d1dd856..ca9d9e8 100644
--- a/tools/marvin/marvin/lib/common.py
+++ b/tools/marvin/marvin/lib/common.py
@@ -1688,8 +1688,11 @@ def verifyVCenterPortGroups(
                 api_client,
                 zoneid=zoneid
             )
-        assert validateList(physicalNetworks)[0] == PASS,\
-                "listPhysicalNetworks returned invalid object in response."
+
+        # If there are no physical networks in zone, return as PASS
+        # as there are no validations to make
+        if validateList(physicalNetworks)[0] != PASS:
+            return [PASS, None]
 
         for physicalNetwork in physicalNetworks:
             trafficTypes = TrafficType.list(

Reply via email to