Coverity issue 1116509 - Assigning the the new returned ResultSet to the rs variable in order to get it closed in the finally block
Signed-off-by: Daan Hoogland <daan.hoogl...@gmail.com> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/c3b4c7a9 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/c3b4c7a9 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/c3b4c7a9 Branch: refs/heads/master Commit: c3b4c7a9cff3f7ecdc0a2465173f56152cc6f9ef Parents: abe0990 Author: wilderrodrigues <wrodrig...@schubergphilis.com> Authored: Thu Jun 4 08:18:17 2015 +0200 Committer: Daan Hoogland <daan.hoogl...@gmail.com> Committed: Thu Jun 4 12:34:04 2015 +0200 ---------------------------------------------------------------------- engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/c3b4c7a9/engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java ---------------------------------------------------------------------- diff --git a/engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java b/engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java index 653124f..bc9c2f0 100644 --- a/engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java +++ b/engine/schema/src/com/cloud/upgrade/dao/VersionDaoImpl.java @@ -108,7 +108,7 @@ public class VersionDaoImpl extends GenericDaoBase<VersionVO, Long> implements V rs.close(); pstmt.close(); pstmt = conn.prepareStatement("SELECT is_static_nat from firewall_rules"); - pstmt.executeQuery(); + rs = pstmt.executeQuery(); return "2.2.1"; } catch (final SQLException e) { s_logger.debug("Assuming the exception means static_nat field doesn't exist in firewall_rules table, returning version 2.2.2");
