CLOUDSTACK-8660 - Adding new StringUtils.getDefaultCharset() in order to wrap
the Charset equivalet method.
- This test was added in order to cover the new
StringUtils.getDefaultCharset().
- One cannot be sure that StringUtils.getPreferredCharset() will always be
equals to Charset.defaultCharset()
Signed-off-by: wilderrodrigues <[email protected]>
This closes #616
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d632d631
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d632d631
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d632d631
Branch: refs/heads/master
Commit: d632d6312b99f8dbd75f8185a4c1e54c7f3e8d05
Parents: 245c976
Author: wilderrodrigues <[email protected]>
Authored: Wed Jul 22 16:27:56 2015 +0200
Committer: wilderrodrigues <[email protected]>
Committed: Thu Jul 23 08:08:46 2015 +0200
----------------------------------------------------------------------
utils/src/com/cloud/utils/StringUtils.java | 4 ++++
utils/test/com/cloud/utils/StringUtilsTest.java | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/d632d631/utils/src/com/cloud/utils/StringUtils.java
----------------------------------------------------------------------
diff --git a/utils/src/com/cloud/utils/StringUtils.java
b/utils/src/com/cloud/utils/StringUtils.java
index 02a616b..76f7806 100644
--- a/utils/src/com/cloud/utils/StringUtils.java
+++ b/utils/src/com/cloud/utils/StringUtils.java
@@ -52,6 +52,10 @@ public class StringUtils {
return Charset.isSupported(UTF8);
}
+ public static Charset getDefaultCharset() {
+ return Charset.defaultCharset();
+ }
+
public static String join(final Iterable<? extends Object> iterable, final
String delim) {
final StringBuilder sb = new StringBuilder();
if (iterable != null) {
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/d632d631/utils/test/com/cloud/utils/StringUtilsTest.java
----------------------------------------------------------------------
diff --git a/utils/test/com/cloud/utils/StringUtilsTest.java
b/utils/test/com/cloud/utils/StringUtilsTest.java
index a9eeac7..3619ede 100644
--- a/utils/test/com/cloud/utils/StringUtilsTest.java
+++ b/utils/test/com/cloud/utils/StringUtilsTest.java
@@ -42,7 +42,11 @@ public class StringUtilsTest {
@Test
public void testGetDefaultCharset() {
- assertEquals(StringUtils.getPreferredCharset(),
Charset.defaultCharset());
+ // Is this test irrelevant? Is wrapping the Charset.defaultCharset()
too much?
+ // This test was added in order to cover the new
StringUtils.getDefaultCharset().
+ // One cannot be sure that StringUtils.getPreferredCharset() will
always be
+ // equals to Charset.defaultCharset()
+ assertEquals(StringUtils.getDefaultCharset(),
Charset.defaultCharset());
}
@Test
