Merge pull request #995 from kansal/CLOUDSTACK-9002 CLOUDSTACk-9002: VM deployment is successful even when dhcp entry command fails - Fixed
Reason: The return value of the call to accept() function in the applyRules() function of BasicNetworkTopology.java was not checked for success or failure. As a result even if it fails, exception was not thrown and VM deployment went ahead without any errors. Fix: Added the necessary checks. * pr/995: CLOUDSTACk-9002: VM deployment is successful even when dhcp entry command fails - Fixed Signed-off-by: Remi Bergsma <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/0c52f70b Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/0c52f70b Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/0c52f70b Branch: refs/heads/master Commit: 0c52f70b45d3c4753adc18e2a45f0cd648b61ff6 Parents: 3d213b6 301ea33 Author: Remi Bergsma <[email protected]> Authored: Mon Nov 2 14:18:21 2015 +0100 Committer: Remi Bergsma <[email protected]> Committed: Mon Nov 2 14:18:21 2015 +0100 ---------------------------------------------------------------------- .../engine/orchestration/NetworkOrchestrator.java | 10 +++++++--- .../cloudstack/network/topology/BasicNetworkTopology.java | 3 +-- 2 files changed, 8 insertions(+), 5 deletions(-) ----------------------------------------------------------------------
