Merge pull request #1328 from borisroman/nullpointer_nicprofilehelperimpl NicProfileHelperImpl NullpointerException when ipVO is nullWhen a VPC has a private gateway, and one would like to restart the VPC with **cleanup** it would fail.
This PR adds a NullPointer check and verifies it with an integration test. ``` test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_01_vpc_privategw_acl | Status : SUCCESS === ok test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS === ok test_03_vpc_privategw_restart_vpc_cleanup (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_03_vpc_privategw_restart_vpc_cleanup | Status : SUCCESS === ok test_04_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_04_rvpc_privategw_static_routes | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 4 tests in 2945.055s OK ``` * pr/1328: Add integration test for restartVPC with cleanup, and Private Gateway enabled. Nullpointer Exception in NicProfileHelperImpl Signed-off-by: Remi Bergsma <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/4dabd131 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/4dabd131 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/4dabd131 Branch: refs/heads/4.7 Commit: 4dabd1311c580507fee154d5e791f4908976e4f6 Parents: c13c554 de11b73 Author: Remi Bergsma <[email protected]> Authored: Sat Jan 16 20:15:51 2016 +0100 Committer: Remi Bergsma <[email protected]> Committed: Sat Jan 16 20:15:52 2016 +0100 ---------------------------------------------------------------------- .../network/router/NicProfileHelperImpl.java | 7 +++- test/integration/smoke/test_privategw_acl.py | 34 ++++++++++++++++++-- 2 files changed, 38 insertions(+), 3 deletions(-) ----------------------------------------------------------------------
