Merge pull request #1334 from nitin-maharana/CloudStack-Nitin17_4.7 CLOUDSTACK-9229: Autoscale policy creation failing in VPC due to zone id missing in createAutoScaleVmProfileAutoscale policy creation is failing on VPC while creating autoscalevmprofile since zoneid parameter is missing.
Steps to Reproduce: ================ 1. Create VPC Network offering with NS as service provider for LB 2. Create VPC using offering which has NetScaler as LB provider 3. Add a tier using the network offering created in Step1 4. Launch a VM 5. Acquire a public IP 6. Create an auto scale policy with all required parameters on an LB rule Result: ====== Fails during autoscalevmprofile creation with the following error: GET command=createAutoScaleVmProfile&response=json&serviceofferingid=05ac866f-604c-43e2-a48b-47e83ef7c4f1&templateid=3cdd83c4-ad27-11e5-9eaf-42407779c24b&destroyvmgraceperiod=30&counterparam%5B0%5D.name=snmpcommunity&counterparam%5B0%5D.value=public&counterparam%5B1%5D.name=snmpport&counterparam%5B1%5D.value=161&_=1451458073663 DEBUG [o.a.c.a.BaseCmd] (catalina-exec-10:ctx-58bcf6cf ctx-f5123e30) (logid:ae6742c8) Ignoring paremeter fordisplay as the caller is not authorized to pass it in INFO [c.c.a.ApiServer] (catalina-exec-10:ctx-58bcf6cf ctx-f5123e30) (logid:ae6742c8) Unable to execute API command autoscalevmprofile due to missing parameter zoneid Expected Result: ============= Autoscale policy creation should be successful and the "min" number of VMs specified in the policy should be deployed. Following should be the params for autoscalevmprofile creation: command=createAutoScaleVmProfile&response=json&zoneid=0b43fff3-c069-417b-ac0c-e4dc46b407ea&serviceofferingid=0 5ac866f-604c-43e2-a48b-47e83ef7c4f1&templateid=3cdd83c4-ad27-11e5-9eaf-42407779c24b&destroyvmgraceperiod=30&counterparam%5B0%5D .name=snmpcommunity&counterparam%5B0%5D.value=public&counterparam%5B1%5D.name=snmpport&counterparam%5B1%5D.value=161 Fix: === Added a conditon to check whether the zoneid in networks is undefined, If that is undefined, it gets the zoneid from ipaddresses argument. Fixed a localization issue. * pr/1334: CLOUDSTACK-9229: Autoscale policy creation failing in VPC due to zoneid missing in createAutoScaleVmProfile Signed-off-by: Remi Bergsma <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/83615959 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/83615959 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/83615959 Branch: refs/heads/master Commit: 8361595946dc26662b8181c92de4faaae4cc3c40 Parents: c14183b 8e77815 Author: Remi Bergsma <[email protected]> Authored: Wed Jan 20 22:31:51 2016 +0100 Committer: Remi Bergsma <[email protected]> Committed: Wed Jan 20 22:31:51 2016 +0100 ---------------------------------------------------------------------- ui/scripts/autoscaler.js | 2 +- ui/scripts/ui-custom/autoscaler.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ----------------------------------------------------------------------
