Merge pull request #1287 from DaanHoogland/securityrules-cleanup SecurityGroupRulesCmd code cleanupWrote a test and cleaned some duplicate code with the objective to evaluate the jenkins pull request process at builds.a.o worthwhile to keep, IMHO.
* pr/1287: SecurityGroupRulesCmd code cleanup review comments handled deal with PMD warnings code cleanup security rules test remove autogenerated pydev files Signed-off-by: Koushik Das <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d1def0a7 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d1def0a7 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d1def0a7 Branch: refs/heads/master Commit: d1def0a73071f0c2ba18a13a6e9cf8d91f3ed20b Parents: 67b4e66 b9b5967 Author: Koushik Das <[email protected]> Authored: Mon Apr 11 21:49:56 2016 +0530 Committer: Koushik Das <[email protected]> Committed: Mon Apr 11 21:49:57 2016 +0530 ---------------------------------------------------------------------- .gitignore | 2 + .../cloud/agent/api/SecurityGroupRulesCmd.java | 252 +++++------- .../agent/api/SecurityGroupRulesCmdTest.java | 93 +++++ .../networkservice/SecurityGroupHttpClient.java | 410 +++++++++---------- ...LibvirtSecurityGroupRulesCommandWrapper.java | 2 +- .../resource/LibvirtComputingResourceTest.java | 22 +- .../cloud/ovm/hypervisor/OvmResourceBase.java | 4 +- .../cloud/agent/manager/MockVmManagerImpl.java | 2 +- .../CitrixSecurityGroupRulesCommandWrapper.java | 2 +- .../xenbase/CitrixRequestWrapperTest.java | 14 +- .../security/SecurityGroupManagerImpl2.java | 4 +- 11 files changed, 447 insertions(+), 360 deletions(-) ----------------------------------------------------------------------
