Merge pull request #1609 from pdube/network-acl-add-order [CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule orderingBUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
The issue occurred because all of the ACL rules get inserted before the old ones. Then, the cleanup deletes the duplicate rows, and leaves any new rule in front of the old ones. Here is an example with a simplified iptables view for ACL Ex: adding a rule 4 before add: 1,2,3 during add: 1',2',3',4',1,2,3 after add: 4',1,2,3 After fix: before add: 1,2,3 during add: 1,2,3,1',2',3',4' after add: 1',2',3',4' * pr/1609: Added fix for adding/editing Network ACL rule ordering Signed-off-by: Will Stevens <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a566cde1 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a566cde1 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a566cde1 Branch: refs/heads/4.9-bountycastle-daan Commit: a566cde145391e370632449b5ee5069664c05bcc Parents: bb9d94b 6dd6ef0 Author: Will Stevens <[email protected]> Authored: Mon Jul 18 14:11:13 2016 -0400 Committer: Will Stevens <[email protected]> Committed: Mon Jul 18 14:11:13 2016 -0400 ---------------------------------------------------------------------- .../debian/config/opt/cloud/bin/cs/CsNetfilter.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) ----------------------------------------------------------------------
