koushik-das commented on a change in pull request #1832: CLOUDSTACK-9652 Job
framework - Cancelling async jobs
URL: https://github.com/apache/cloudstack/pull/1832#discussion_r114256584
##########
File path: engine/components-api/src/com/cloud/agent/AgentManager.java
##########
@@ -80,9 +81,9 @@
* should the agent stop execution on the first error.
* @return an array of Answer
*/
- Answer[] send(Long hostId, Commands cmds) throws
AgentUnavailableException, OperationTimedoutException;
+ Answer[] send(Long hostId, Commands cmds) throws
AgentUnavailableException, OperationTimedoutException,
OperationCancelledException;
- Answer[] send(Long hostId, Commands cmds, int timeout) throws
AgentUnavailableException, OperationTimedoutException;
+ Answer[] send(Long hostId, Commands cmds, int timeout) throws
AgentUnavailableException, OperationTimedoutException,
OperationCancelledException;
Review comment:
Shouldn't the below send() just below it also throw
OperationCancelledException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
